Skip to content

crypto: DRY Diffie-Hellman initialization code #23657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bnoordhuis wants to merge 1 commit into from
Closed

crypto: DRY Diffie-Hellman initialization code #23657

bnoordhuis wants to merge 1 commit into from

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Oct 14, 2018

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 14, 2018

@bnoordhuis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1243/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 14, 2018
richardlau
richardlau reviewed Oct 14, 2018
View reviewed changes
addaleax
addaleax approved these changes Oct 14, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to share these methods instead of creating duplicates, e.g. through inheritance or SetPrototypeProviderTemplate()?

@bnoordhuis
Copy link
Member Author

bnoordhuis commented Oct 15, 2018

Rebased to fix merge conflict.

Would it make sense to share these methods instead of creating duplicates, e.g. through inheritance or SetPrototypeProviderTemplate()?

env->SetMethod(proto_provider_templ, ...) restricts calls to proto_provider_templ due to the v8::Signature. Either new methods are needed (potential source of confusion) or we inline it in DiffieHellman::Initialize(), but either way the PR then adds more code than it removes.

@jasnell
Copy link
Member

jasnell commented Oct 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17922/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2018
@jasnell
Copy link
Member

jasnell commented Oct 17, 2018

Resuming CI: https://ci.nodejs.org/job/node-test-pull-request/17946/

@tniessen
Copy link
Member

tniessen commented Oct 17, 2018

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/17951/

@refack
Copy link
Contributor

refack commented Oct 18, 2018

CI in green.

@danbev
Copy link
Contributor

danbev commented Oct 18, 2018

Landed in 92d67fe.

@danbev danbev closed this Oct 18, 2018
danbev pushed a commit that referenced this pull request Oct 18, 2018
@bnoordhuis @danbev
crypto: DRY Diffie-Hellman initialization code
92d67fe 
PR-URL: #23657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@bnoordhuis @jasnell
crypto: DRY Diffie-Hellman initialization code
1336830 
PR-URL: #23657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@bnoordhuis @nodejs-github-bot @jasnell @tniessen @refack @danbev @addaleax @cjihrig @richardlau