Skip to content

test: Remove usc-2 and usc2 #21965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost wants to merge 1 commit into from
Closed

test: Remove usc-2 and usc2 #21965

ghost wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Jul 25, 2018 •
edited by ghost
Loading

Ref: #21963

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Jul 25, 2018
benjamingr
benjamingr approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @BridgeAR

@benjamingr benjamingr requested a review from BridgeAR July 25, 2018 07:42
@BridgeAR
Copy link
Member

BridgeAR commented Jul 25, 2018

This should land before #21964. Otherwise this change should be included directly in the mentioned PR.

@silverwind
Copy link
Contributor

silverwind commented Jul 25, 2018

#21964 is now a superset of this PR. I'd say we close this one.

@ghost
Copy link
Author

ghost commented Jul 26, 2018

Since #21964 has added benchmark tests, so this is duplicated and close this.

@ghost ghost closed this Jul 26, 2018
@ghost ghost deleted the BufferSupportUSC2 branch July 26, 2018 01:16
@ghost ghost mentioned this pull request Aug 1, 2018
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BridgeAR @silverwind @benjamingr @ChALkeR @nodejs-github-bot