Skip to content

src: fix formatting of PIDs #21852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tniessen wants to merge 1 commit into from
Closed

src: fix formatting of PIDs #21852

tniessen wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jul 17, 2018

uv_pid_t seems to be signed on all supported platforms, so %d seems appropriate.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 17, 2018

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/294/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 17, 2018
@maclover7
Copy link
Contributor

maclover7 commented Jul 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15962/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 20, 2018
tniessen added a commit that referenced this pull request Jul 22, 2018
@tniessen
src: fix formatting of PIDs
8ac9163 
PR-URL: #21852
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@tniessen
Copy link
Member Author

tniessen commented Jul 22, 2018

Landed in 8ac9163.

@tniessen tniessen closed this Jul 22, 2018
targos pushed a commit that referenced this pull request Jul 24, 2018
@tniessen @targos
src: fix formatting of PIDs
4f8620e 
PR-URL: #21852
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@trivikr trivikr trivikr approved these changes

+1 more reviewer

@maclover7 maclover7 maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tniessen @nodejs-github-bot @maclover7 @jasnell @lpinca @joyeecheung @trivikr