crypto: deprecate Decipher.finaltol #19353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
the
semver-major
nodejs-github-bot
added
the
crypto
addaleax
approved these changes
Mar 14, 2018
bnoordhuis
approved these changes
Mar 14, 2018
Member
Author
cjihrig
approved these changes
Mar 14, 2018
mscdex
reviewed
Mar 14, 2018
doc/api/deprecations.md
Outdated
| property to a string before assigning it to `process.env`. | ||
| <a id="DEP00XX"></a> | ||
| ### DEP00XX: crypto.Decipher.finaltol |
Contributor
There was a problem hiding this comment.
Should Decipher here and below be lowercased since it's referring to a prototype method and not a static method?
Member
Author
There was a problem hiding this comment.
I agree that decipher.finaltol is better than Decipher.finaltol here, but crypto.decipher.finaltol looks weird (since there is no decipher property on crypto). I changed all occurrences to lowercase and removed the crypto. prefix. Is there a better way to do this?
Contributor
There was a problem hiding this comment.
I think what dropping crypto. and using lowercase is fine, especially since .final() is linked to and should give enough context.
danbev
approved these changes
Mar 15, 2018
jasnell
approved these changes
Mar 15, 2018
lpinca
approved these changes
Mar 16, 2018
lpinca
added
the
author ready
tniessen
added a commit
that referenced
this pull request
Mar 18, 2018
PR-URL: #19353 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
Author
|
Landed in 19f3927, deprecation code is DEP0105. |
tniessen
removed
the
author ready
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Apr 11, 2018
3 tasks
jasnell
pushed a commit
that referenced
this pull request
Apr 14, 2018
Refs: #19353 PR-URL: #19941 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since eaf1343,
Decipher.finaltol()has been an undocumented alias forDecipher.final(). Sadly, @bnoordhuis comment ("remove someday") was lost at some point in the last six years, but I believe the time has finally come.The function has never been documented, it has no advantage over
.final(), there is exactly one test which uses it, and there seems to be absolutely no usage on GitHub.cc @danbev
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes