doc: un-mark Socket#write “removal” as notable change #18083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the method is inherited from `Writable`, usage of the method does not change at all after its removal as an explicit method. Calling it out as notable might therefore be more confusing than helpful.
cjihrig
approved these changes
Jan 10, 2018
lpinca
approved these changes
Jan 10, 2018
Member
Author
|
Landed in 6e3818f |
addaleax
added a commit
that referenced
this pull request
Jan 10, 2018
Since the method is inherited from `Writable`, usage of the method does not change at all after its removal as an explicit method. Calling it out as notable might therefore be more confusing than helpful. PR-URL: #18083 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
added a commit
that referenced
this pull request
Jan 10, 2018
Since the method is inherited from `Writable`, usage of the method does not change at all after its removal as an explicit method. Calling it out as notable might therefore be more confusing than helpful. PR-URL: #18083 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
added a commit
to addaleax/nodejs.org
that referenced
this pull request
Jan 10, 2018
Applied from nodejs/node#18083 --- doc: un-mark Socket#write “removal” as notable change Since the method is inherited from `Writable`, usage of the method does not change at all after its removal as an explicit method. Calling it out as notable might therefore be more confusing than helpful.
addaleax
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jan 10, 2018
Applied from nodejs/node#18083 --- doc: un-mark Socket#write “removal” as notable change Since the method is inherited from `Writable`, usage of the method does not change at all after its removal as an explicit method. Calling it out as notable might therefore be more confusing than helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the method is inherited from
Writable, usage of the methoddoes not change at all after its removal as an explicit method.
Calling it out as notable might therefore be more confusing than
helpful.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)