doc: multiple minor fixes to BUILDING.md #17985
Closed
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
richardlau
approved these changes
Jan 5, 2018
hiroppy
approved these changes
Jan 5, 2018
maclover7
approved these changes
Jan 5, 2018
Contributor
lpinca
approved these changes
Jan 5, 2018
BUILDING.md
Outdated
Member
There was a problem hiding this comment.
Nit: I'd realign the "Architectures" and "Notes" columns.
jasnell
approved these changes
Jan 5, 2018
Trott
force-pushed
the
building-copyedit
branch
from
815a66f to
23c299f
Compare
cjihrig
approved these changes
Jan 5, 2018
gibfahn
approved these changes
Jan 7, 2018
jasnell
pushed a commit
that referenced
this pull request
Jan 10, 2018
* remove spaces around slash in BUILDING.md * hyphenate _end-of-life_ in BUILDING.md * add missing comma in BUILDING.md * add missing backticks in BUILDING.md * add missing comma to BUILDING.md PR-URL: #17985 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Member
|
Landed in ec00ee8 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 22, 2018
* remove spaces around slash in BUILDING.md * hyphenate _end-of-life_ in BUILDING.md * add missing comma in BUILDING.md * add missing backticks in BUILDING.md * add missing comma to BUILDING.md PR-URL: #17985 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
* remove spaces around slash in BUILDING.md * hyphenate _end-of-life_ in BUILDING.md * add missing comma in BUILDING.md * add missing backticks in BUILDING.md * add missing comma to BUILDING.md PR-URL: #17985 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Contributor
|
Setting as don't land for v6.x and v8.x, please feel free to change labels and backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc