Skip to content

doc: Update es module loader example to use module.builtinModules #17385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 2 commits into from
Closed

doc: Update es module loader example to use module.builtinModules #17385

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbe7afc
doc: esm loader example with module.builtinModules
guybedford Nov 29, 2017
fa26939
use Module over module in example to avoid confusion
guybedford Dec 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,13 @@ be written:
import url from 'url';
import path from 'path';
import process from 'process';
import module from 'module';
Copy link
Member

@jdalton jdalton Nov 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe capital Module to reduce confusion with the CJS form.

Copy link
Contributor Author

@guybedford guybedford Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only saw this now for some reason, sounds sensible!


const builtins = new Set(
Object.keys(process.binding('natives')).filter((str) =>
/^(?!(?:internal|node|v8)\/)/.test(str))
);
const builtins = module.builtinModules;
const JS_EXTENSIONS = new Set(['.js', '.mjs']);

export function resolve(specifier, parentModuleURL/*, defaultResolve */) {
if (builtins.has(specifier)) {
if (builtins.includes(specifier)) {
return {
url: specifier,
format: 'builtin'
Expand Down