stream: fix todo #15667
Closed
stream: fix todo #15667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the update to v8 6.1 this todo can now be addressed.
nodejs-github-bot
added
the
stream
bmeurer
approved these changes
Sep 29, 2017
Member
bmeurer
left a comment
bmeurer
left a comment
There was a problem hiding this comment.
Indeed, thanks for cleaning this up.
hiroppy
approved these changes
Sep 29, 2017
lpinca
approved these changes
Sep 29, 2017
jasnell
approved these changes
Sep 29, 2017
Member
Author
|
Landed in 564d7ef |
BridgeAR
added a commit
that referenced
this pull request
Oct 1, 2017
With the update to v8 6.1 this todo can now be addressed. PR-URL: #15667 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
With the update to v8 6.1 this todo can now be addressed. PR-URL: #15667 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
With the update to v8 6.1 this todo can now be addressed. PR-URL: #15667 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
With the update to v8 6.1 this todo can now be addressed. PR-URL: nodejs/node#15667 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
With the update to v8 6.1 this todo can now be addressed. PR-URL: #15667 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update to v8 6.1 this todo can now be addressed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
stream