src: fix build on certain platforms #14996
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Aug 24, 2017
Member
|
+1 on fast tracking :-) ... assuming we can get CI to stay up long enough to do an actual test. |
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd
addaleax
changed the title
Member
Author
|
Updated the PR & did the same thing for HTTP2 where this worked out by accident because there was an even number of |
Member
|
Yep, it was a bug waiting to happen in the http2 code too. Those fields are quite likely to change. Thank you for including those. |
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-commit/11990/ Already got some buildbot failures so we might be trying again soon |
Member
|
The other run is almost complete, starting a new one see if we can get past the buildbot failures https://ci.nodejs.org/job/node-test-pull-request/9814/ |
refack
approved these changes
Aug 24, 2017
Contributor
|
+1 for fast tracking.
BTW: You can stop the job then hit "rebuild", that will only retry the incomplete/failed subjobs. |
Member
|
This is looking good so far. I did push a commit in to comment out a flaky precision comparison in one of the tests (it's the first time I've seen it.. and I'll revisit it in a separate PR.). Assuming this run is clear I'll land shortly. |
Member
|
Yes i know we can "rebuild" on the CI. Given the build bot failures I wanted to do a complete fresh rerun. |
jasnell
pushed a commit
that referenced
this pull request
Aug 24, 2017
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: #14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Member
|
Landed in 86c4655 |
2 tasks
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Aug 25, 2017
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: nodejs/node#14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
added a commit
to ayojs/ayo
that referenced
this pull request
Aug 28, 2017
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: nodejs/node#14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: #14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: #14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: #14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
doublefields inperformance_statecould previously havebeen aligned at 4-byte instead of 8-byte boundaries, which would
have made creating an Float64Array them as a array buffer view
for an ArrayBuffer extending over the entire struct an invalid
operation.
Ref: 67269fd
Would suggest fast-tracking to unbreak CI, assuming this works.
/cc @jasnell