tools: use error instead of 2
#14061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
approved these changes
Jul 3, 2017
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
+1 for change, content LGTM
Contributor
Author
Contributor
Contributor
Author
targos
approved these changes
Jul 3, 2017
vsemozhetbyt
approved these changes
Jul 3, 2017
cjihrig
approved these changes
Jul 3, 2017
fhinkel
approved these changes
Jul 3, 2017
lpinca
approved these changes
Jul 4, 2017
BridgeAR
approved these changes
Jul 5, 2017
PR-URL: nodejs#14061 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refack
force-pushed
the
eslint-rules-2-to-error
branch
from
5c1c0f4 to
46d7cb8
Compare
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #14061 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #14061 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
PR-URL: #14061 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
|
Should this be backported to |
2 tasks
Contributor
Author
|
Backport PR: #14841 |
refack
added a commit
to refack/node
that referenced
this pull request
Sep 19, 2017
PR-URL: nodejs#14061 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> # Conflicts: # .eslintrc.yaml # benchmark/.eslintrc.yaml # doc/.eslintrc.yaml # test/.eslintrc.yaml # tools/.eslintrc.yaml
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
Backport-PR-URL: #14841 PR-URL: #14061 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already using the "cleaner" YAML variant, so why not use the
errorsymbol instead of the quite confusing2value?Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools