Skip to content

(v6.x-staging) test: skip when openssl CLI doesn't exist #12173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sotayamashita wants to merge 12 commits into from
Closed

(v6.x-staging) test: skip when openssl CLI doesn't exist #12173

sotayamashita wants to merge 12 commits into from

Conversation

@sotayamashita
Copy link
Contributor

@sotayamashita sotayamashita commented Apr 3, 2017

PR-URL: #11095
Reviewed-By: James M Snell [email protected]
Reviewed-By: Yuta Hiroto [email protected]
Reviewed-By: Gibson Fahnestock [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Sakthipriyan Vairamani [email protected]
Reviewed-By: Sam Roberts [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines][]

sam-github and others added 12 commits March 21, 2017 22:26
@sam-github @MylesBorins
deps: upgrade zlib to 1.2.11
8383742 
PR-URL: #10980
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@mhdawson @jasnell
doc: add supported platforms list
74a7a1d 
Original Commit Message:
  PR-URL: #11872
  Reviewed-By: James M Snell <[email protected]>
  Reviewed-By: Rich Trott <[email protected]>
  Reviewed-By: Roman Reiss <[email protected]>
  Reviewed-By: Ben Noordhuis <[email protected]>
  Reviewed-By: Gibson Fahnestock <[email protected]>

Backport-Of: #11872
PR-URL: #11943
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mhdawson @jasnell
doc: add supported platforms list for v6.x
6803521 
PR-URL: #11943
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@sushi90 @MylesBorins
doc: fix broken URL to event loop guide
47cdeb9 
PR-URL: #11670
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mscdex @MylesBorins
stream: avoid additional validation for Buffers
a0e1b1e 
These changes result in ~50% improvement in the included benchmark.

PR-URL: #10580
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos @MylesBorins
deps: backport 2cabc86 from upstream V8
5dd167b 
Original commit message:

    Fix classifier related bug

    [email protected]
    BUG=chromium:621111
    LOG=N

    Review-Url: https://codereview.chromium.org/2086513002
    Cr-Commit-Position: refs/heads/master@{#37150}

Fixes: #11977

PR-URL: #12037
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@targos @MylesBorins
deps: cherry-pick b9f682b from upstream V8
78e27f4 
Original commit message:

    Fix bug with illegal spread as single arrow parameter

    [email protected]
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{#37196}

Fixes: #12017

PR-URL: #12037
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@targos @MylesBorins
deps: backport e427300 from upstream V8
fb320bf 
Original commit message:

    Properly handle holes following spreads in array literals

    Before this change, the spread desugaring would naively call
    `%AppendElement($R, the_hole)` and in some cases $R would have
    a non-holey elements kind, putting the array into the bad state
    of exposing holes to author code.

    This patch avoids calling %AppendElement with a hole, instead
    simply incrementing $R.length when it sees a hole in the literal
    (this is safe because $R is known to be an Array). The existing
    logic for elements transitions takes care of giving the array a
    holey ElementsKind.

    BUG=chromium:644215

    Review-Url: https://codereview.chromium.org/2321533003
    Cr-Commit-Position: refs/heads/master@{#39294}

Fixes: #12018

PR-URL: #12037
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins
crypto: fix memory leak if certificate is revoked
0490736 
The additional validity checks applied to StartCom and WoSign
certificates failed to free memory before returning.

Refs: #9469
Fixes: #12033
PR-URL: #12089
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@sam-github @MylesBorins
deps: fix CLEAR_HASH macro to be usable as a single statement
54adf37 
Apply unreleased (as of zlib v1.2.11) patch from upstream:
- madler/zlib@38e8ce3

Original commit message:
  Fix CLEAR_HASH macro to be usable as a single statement.

  As it is used in deflateParams().

PR-URL: #11616
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Revert "Revert "repl: disable Ctrl+C support..."
59b869e 
Full original message:

  Revert "repl: disable Ctrl+C support on win32 for now"

The original fix was a stop gap until a libuv update landed.
As the libuv update has not yet landed on v6.x the revert should
not have landed. This commit reverts 1d400ea reapplying the
stopgap fix until we update libuv.

Fixes: #12085
Refs: #8645

PR-URL: #12123
Reviewed-By: Anna Henningsen <[email protected]>
@sotayamashita
test: skip when openssl CLI doesn't exist
3a1cc79 
PR-URL: #11095
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Apr 3, 2017
@sotayamashita sotayamashita changed the title test: skip when openssl CLI doesn't exist (v6.x-staging) test: skip when openssl CLI doesn't exist Apr 3, 2017
@hiroppy hiroppy added the openssl Issues and PRs related to the OpenSSL dependency. label Apr 3, 2017
@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 13, 2017 •
edited
Loading

landed in 0695c09

MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
@sotayamashita @MylesBorins
test: skip when openssl CLI doesn't exist
0695c09 
Backport-PR-URL: #12173
PR-URL: #11095
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@sotayamashita sotayamashita deleted the test-openssl-cli-v6-backport branch April 16, 2017 01:49
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@sotayamashita @MylesBorins
test: skip when openssl CLI doesn't exist
f874256 
Backport-PR-URL: #12173
PR-URL: #11095
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@sotayamashita @andrew749
test: skip when openssl CLI doesn't exist
5854fa3 
Backport-PR-URL: nodejs/node#12173
PR-URL: nodejs/node#11095
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.