deps backport 7c3748a from upstream V8#10881
Closed
cristiancavalli wants to merge 1 commit intonodejs:v6.xfrom
Closed
deps backport 7c3748a from upstream V8#10881cristiancavalli wants to merge 1 commit intonodejs:v6.xfrom
cristiancavalli wants to merge 1 commit intonodejs:v6.xfrom
Conversation
nodejs-github-bot
added
v6.x
v8 engine
Author
|
cc @ofrobots |
Contributor
|
That patch looks much better than it needs to. I am not sure why github is displaying the patch so strangely at v8/v8@7c3748a. If you look at the patch in the code review upstream https://codereview.chromium.org/2045863002 (direct link to patch) it doesn't include any of the e.g. I think you should apply the upstream patch. |
cristiancavalli
force-pushed
the
backport-07d0f6d-0.6x
branch
from
7889580 to
6c5f9db
Compare
Author
|
@ofrobots updated |
cristiancavalli
force-pushed
the
backport-07d0f6d-0.6x
branch
from
6c5f9db to
df1783c
Compare
cristiancavalli
changed the title
Original commit message:
load correct stack slot for frame details.
R=bmeurer@chromium.org
BUG=v8:5071
Review URL: https://codereview.chromium.org/2045863002 .
Cr-Commit-Position: refs/heads/master@{nodejs#36769}
Contributor
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Original commit message:
load correct stack slot for frame details.
R=bmeurer@chromium.org
BUG=v8:5071
Review URL: https://codereview.chromium.org/2045863002 .
Cr-Commit-Position: refs/heads/master@{#36769}
PR-URL: #10881
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Contributor
|
landed in f3b7408 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Original commit message:
load correct stack slot for frame details.
R=bmeurer@chromium.org
BUG=v8:5071
Review URL: https://codereview.chromium.org/2045863002 .
Cr-Commit-Position: refs/heads/master@{#36769}
PR-URL: #10881
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
Original commit message:
load correct stack slot for frame details.
R=bmeurer@chromium.org
BUG=v8:5071
Review URL: https://codereview.chromium.org/2045863002 .
Cr-Commit-Position: refs/heads/master@{#36769}
PR-URL: #10881
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps
V8 commit:
v8/v8@7c3748a
Description of change:
Backport of bugfix from upstream V8
Original commit message:
load correct stack slot for frame details.
R=bmeurer@chromium.org
BUG=v8:5071
Review URL: https://codereview.chromium.org/2045863002 .
Cr-Commit-Position: refs/heads/master@{#36769}