Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Jan 8, 2017

Original commit message:

fix stepping out of across throwing.

R=[email protected]
BUG=v8:5559

Review-Url: https://codereview.chromium.org/2445233004
Cr-Commit-Position: refs/heads/master@{#40549}

Fixes: #9175

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Original commit message:

  fix stepping out of across throwing.

  [email protected]
  BUG=v8:5559

  Review-Url: https://codereview.chromium.org/2445233004
  Cr-Commit-Position: refs/heads/master@{nodejs#40549}

Fixes: nodejs#9175
@targos targos added debugger v8 engine Issues and PRs related to the V8 dependency. labels Jan 8, 2017
@nodejs-github-bot nodejs-github-bot added v6.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 8, 2017
@targos targos changed the title deps: cherry-pick baba152 from V8 upstream v6.x: deps: cherry-pick baba152 from V8 upstream Jan 9, 2017
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

jasnell pushed a commit that referenced this pull request Jan 10, 2017
Original commit message:

  fix stepping out of across throwing.

  [email protected]
  BUG=v8:5559

  Review-Url: https://codereview.chromium.org/2445233004
  Cr-Commit-Position: refs/heads/master@{#40549}

PR-URL: #10689
Fixes: #9175
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

Landed in cf564d0

@jasnell jasnell closed this Jan 10, 2017
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Original commit message:

  fix stepping out of across throwing.

  [email protected]
  BUG=v8:5559

  Review-Url: https://codereview.chromium.org/2445233004
  Cr-Commit-Position: refs/heads/master@{#40549}

PR-URL: #10689
Fixes: #9175
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Original commit message:

  fix stepping out of across throwing.

  [email protected]
  BUG=v8:5559

  Review-Url: https://codereview.chromium.org/2445233004
  Cr-Commit-Position: refs/heads/master@{#40549}

PR-URL: #10689
Fixes: #9175
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos deleted the fix-9175-v6 branch June 1, 2017 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants