Skip to content

misc/function_call does not work with the benchmark suite #16154

@joyeecheung

Description

@joyeecheung
  • Version: master
  • Subsystem: benchmark

This benchmark requires running make in the directory to build the addon before it can be run (also the Makefile tries to use the global node-gyp, not the one in the codebase). Currently running it with run.js it will just report misc/function_call.js Binding failed to load.

Should we keep this benchmark? If so, it needs to be fixed to work with our current benchmark suite. The purpose of this benchmark seems to be:

// show the difference between calling a short js function
// relative to a comparable C++ function.
// Reports millions of calls per second.
// Note that JS speed goes up, while cxx speed stays about the same.

sounds useful to me.

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to the benchmark subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions