napi test throws error

[zimbabao]

• Version: v8.0.0-pre ( hash 9516aa1)
• Platform: MacOSX
• Subsystem: napi

make test

Throws following error on mac.

=== release test ===
Path: addons-napi/test_array/test
assert.js:557
    throw actual;
    ^

TypeError: test_array.TestGetElement is not a function
    at assert.throws (/Users/rgaunker/os/node/test/addons-napi/test_array/test.js:24:16)
    at _tryBlock (assert.js:514:5)
    at _throws (assert.js:535:12)
    at Function.throws (assert.js:565:3)
    at Object.<anonymous> (/Users/rgaunker/os/node/test/addons-napi/test_array/test.js:22:8)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
Command: out/Release/node --napi-modules /Users/rgaunker/os/node/test/addons-napi/test_array/test.js
[03:12|% 100|+ 1529|-   3]: Done
make: *** [test] Error 1

[zimbabao]

Likely old napi build folder ./test/addons-napi/test_array/build/ is not cleaned or updated even after code is changed.

[Trott]

My knowledge in this area is limited but: There's a test-addons-clean task in the Makefile that I think is for when things get in a stale state. But it doesn't clean addons-napi nor is there a separate task that does that.

[joyeecheung]

@Trott test-addons-clean was added before napi lands so now it needs an update...I'll open a PR for that.

Meanwhile, does adding rules like test-addons-clean to make clean sound like a good idea? There is also test-gc-clean which cleans up artifacts generated by test-gc (not run if you just make clean, has to be triggered separately). In my experience it's pretty common to bump into stale addon builds when you are switching branches (e.g. when backporting)

[zimbabao]

make clean should clean should clean all or atleast should have target like reallyclean .

[cjihrig]

@zimbabao is this still an issue?

[zimbabao]

@cjihrig : Haven't faced issue anymore. Closing the ticket.