This repository was archived by the owner on Feb 1, 2022. It is now read-only.
fix: replace the deprecated "repl.cli" with "repl"#66
Merged
hybrist merged 1 commit intonodejs:masterfrom May 16, 2019
Merged
Conversation
"REPLServer.rli" is deprecated and it's the reference of the instance. So that we can replace the "repl.cli" with "repl" to remove the deprecation warning in Node.js 12. Refs: nodejs/node#26260
hybrist
approved these changes
May 16, 2019
Collaborator
hybrist
left a comment
hybrist
left a comment
There was a problem hiding this comment.
Thanks a lot! Looking good.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"REPLServer.rli" is deprecated and it's the reference of
the instance. So that we can replace the "repl.cli" with
"repl" to remove the deprecation warning in Node.js 12.
Refs: nodejs/node#26260