Pull latest changes from nodejs/node#45
Merged
MoLow merged 12 commits intonodejs:mainfrom Feb 8, 2023
Merged
Conversation
MoLow
force-pushed
the
pull-latest-changes
branch
2 times, most recently
from
0743c23 to
c24bcb9
Compare
PR-URL: nodejs/node#45712 Fixes: nodejs/node#45648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit a1b27b25bb01aadd3fd2714e4b136db11b7eb85a)
Move the logic for handling --test-reporter out of the general module loader and into the test_runner subsystem. PR-URL: nodejs/node#45923 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 12c0571c8fece32d274eaf0ae197c0eb1948fe11)
This commit addresses an existing TODO in the code by moving to the new os.availableParallelism() instead of os.cpus().length. PR-URL: nodejs/node#45969 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit fe5710effcb0b336853657e424da04407b0e49ad)
PR-URL: nodejs/node#46030 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> (cherry picked from commit 9eb363a3e00dbba572756c7ed314273f17ea8e2e)
This commit updates the test runner to make the built in test reporters internal modules. PR-URL: nodejs/node#46092 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> (cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow
force-pushed
the
pull-latest-changes
branch
from
c24bcb9 to
e50df0e
Compare
PR-URL: nodejs/node#46258 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> (cherry picked from commit 931f035bac8326a11f42fc05463d5b21d9bec502)
PR-URL: nodejs/node#46311 Fixes: nodejs/node#45836 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit 2f38c74e263ed2e7f3b087efb9adee2442dd25c4)
PR-URL: nodejs/node#46441 Fixes: nodejs/node#45910 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 61c65b066b098cf47f89206212864ec1cddb8782)
PR-URL: nodejs/node#46450 Fixes: nodejs/node#45911 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 1118db718c8429f5f343aca90ccb570244e282b4)
PR-URL: nodejs/node#46056 Fixes: nodejs/node#46048 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> (cherry picked from commit 4c08c20e575a0954fe3977a20e9f52b4980a2e48)
MoLow
force-pushed
the
pull-latest-changes
branch
from
17f0e2d to
4796482
Compare
PR-URL: nodejs/node#46457 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> (cherry picked from commit 7d68b7bbfc9ffbd2ad0913972ac0b1a315679b06)
MoLow
force-pushed
the
pull-latest-changes
branch
from
4796482 to
a382788
Compare
aduh95
reviewed
Feb 8, 2023
| } = require('#internal/per_context/primordials') | ||
| const { inspectWithNoCustomRetry } = require('#internal/errors') | ||
| const Readable = require('#internal/streams/readable') | ||
| const { Readable } = require('readable-stream') |
Contributor
There was a problem hiding this comment.
It might be better to keep the require('#internal/streams/readable') here and have the internal module export from readable-stream. That way we would keep the source as close to the Node.js implementation as we can.
Member
Author
There was a problem hiding this comment.
the source is not really close to node core mainly due to the major differences in the linter settings.
also primoadials in core changed to be a global variable, and in this repo, we still require a file - to avoid using a global variable
So I don't really think it matters that much if we require readable-stream directly or not
Contributor
There was a problem hiding this comment.
primordials is not a global variable in core, it's one of the arguments passed to the CJS-like wrapper function. But point taken, if you think it's better this way, I don't see a problem with it.
aduh95
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looking at https://github.com/nodejs/node/commits/main/lib/internal/test_runner
and https://github.com/nodejs/node/commits/main/doc/api/test.md