src: remove TypedArray::unknown_array_type #1209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Marking this as SemVer major out of an abundanc of caution. We don't believe this will affect any code that could be working, but might as well signal as SemVer major just in case. |
mhdawson
pushed a commit
that referenced
this pull request
Oct 14, 2022
PR-URL: #1209 Reviewed-By: Michael Dawson <[email protected]>
Member
|
Landed as a8afb2d |
This was referenced Nov 3, 2022
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#1209 Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
TypedArray::unknown_array_typeand makes the default (if not specified) asnapi_int8_array.Fixes: #1066
Fixes: #1198
Closes: #1162