This repository was archived by the owner on Apr 16, 2020. It is now read-only.
Closed
Conversation
Author
|
Kept it short, sweet, and noncontroversial as possible. Feedback welcome. |
devsnek
suggested changes
Mar 9, 2019
doc/api/esm.md
Outdated
|
|
||
| ECMAScript modules are the official standard format to package Javascript code for reuse. Modules are defined using a variety of [import][] and [export][] statements. | ||
|
|
||
| Node fully supports the format as it is currently specified, as well as provides limited compatibility with the existing module (CommonJS) format. |
Member
There was a problem hiding this comment.
Suggested change
| Node fully supports the format as it is currently specified, as well as provides limited compatibility with the existing module (CommonJS) format. | |
| Node.js fully supports ECMAScript modules as they are currently specified and provides limited interoperability between them and the existing module format, CommonJS. |
you should also change the commonjs to a link
Author
There was a problem hiding this comment.
Fixed. The CommonJS link points to the modules doc.
devsnek
previously requested changes
Mar 9, 2019
GeoffreyBooth
approved these changes
Mar 9, 2019
ljharb
reviewed
Mar 9, 2019
MylesBorins
force-pushed
the
modules-lkgr
branch
from
bec588f to
ea59221
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
2 times, most recently
from
c6d1b01 to
b4abd3a
Compare
MylesBorins
approved these changes
Mar 13, 2019
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
LGTM with a tiny nit
|
|
||
| ## Introduction | ||
|
|
||
| ECMAScript modules are the official standard format to package JavaScript code for reuse. Modules are defined using a variety of [`import`][] and [`export`][] statements. |
Contributor
There was a problem hiding this comment.
Suggested change
| ECMAScript modules are the official standard format to package JavaScript code for reuse. Modules are defined using a variety of [`import`][] and [`export`][] statements. | |
| ECMAScript modules are the standard format to package JavaScript code for reuse. Modules are defined using a variety of [`import`][] and [`export`][] statements. |
Contributor
|
@devsnek do you still have any objections? |
Contributor
|
landed in 0a47098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the
Introductionsection for ESM including links to the MDN documentation forimportandexport.Readable Version: