Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 80.79% 80.79% -0.01%
==========================================
Files 119 119
Lines 11864 11864
Branches 843 842 -1
==========================================
- Hits 9586 9585 -1
- Misses 2275 2276 +1
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // TODO(@avivkeller): Ask Orama to support this functionality natively | ||
| /** | ||
| * @param {any} options | ||
| */ | ||
| db.search = options => search(db, options); | ||
|
|
There was a problem hiding this comment.
cc @micheleriva: @orama/ui calls client.search (https://github.com/oramasearch/orama-ui/blob/main/packages/ui/src/hooks/useSearch.tsx#L94), however, the non-Cloud client don't implement this function. Instead, they use search(client, ...) syntax.
Is there a way for Orama to add client.search() functionality to the non-Cloud clients, or support search(client, ...) in the UI library?
There was a problem hiding this comment.
Pull request overview
This PR migrates from the deprecated @orama/react-components package to the new @orama/ui library, updating search functionality to use new UI components from @node-core/ui-components.
Key changes:
- Replaced
@orama/react-componentswith@orama/uiand updated@node-core/ui-componentsto version 1.4.1 - Refactored SearchBox component to use new Modal, Results, and Hit components
- Added workaround in useOrama hook to attach search method to database instance
- Updated Orama database schema, changing
pathfield tohrefand addingsiteSectionfield
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependencies: replaced @orama/react-components with @orama/ui, upgraded @node-core/ui-components |
| npm-shrinkwrap.json | Reflected package.json changes with detailed dependency tree updates and removals |
| src/generators/web/ui/components/SearchBox/index.jsx | Refactored to use new search components from ui-components library |
| src/generators/web/ui/components/SearchBox/config.mjs | Removed theme configuration file (no longer needed) |
| src/generators/web/ui/components/NavBar.jsx | Removed SERVER/CLIENT conditional and TODO comment for SSR support |
| src/generators/web/ui/hooks/useOrama.mjs | Added search method workaround and imported search function |
| src/generators/web/ui/index.css | Added new CSS rules for modal content list items with ellipsis styling |
| src/generators/orama-db/index.mjs | Changed loop start from index 0 to 1 in buildHierarchicalTitle function |
| src/generators/orama-db/constants.mjs | Updated schema: renamed path to href, added siteSection field |
Files not reviewed (1)
- npm-shrinkwrap.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ovflowd
left a comment
There was a problem hiding this comment.
Aye, this is so frigging cool! TYSM for doing this!
This PR is small enough that I feel we can fast-track.
This PR uses the new
@orama/uilibrary