upgrade module to work with latest nodegui (0.57.1)#376
Merged
a7ul merged 5 commits intonodegui:masterfrom Oct 4, 2022
Merged
Conversation
KaMeHb-UA
changed the title
Contributor
Author
|
tested a bit, there is issues with layout, temporary marking this PR as draft |
Contributor
Author
|
fixed basic issues, sample app operates normally but there is still need to check if all the stuff's working well by someone else |
a7ul
approved these changes
Oct 4, 2022
Collaborator
a7ul
left a comment
a7ul
left a comment
There was a problem hiding this comment.
Tested this and it looks amazing.
Thanks for the great work
Collaborator
|
@allcontributors add @KaMeHb-UA for code |
Contributor
|
I've put up a pull request to add @KaMeHb-UA! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+ docs =)
P.S. I hadn't enough time to test all the stuff properly so there may be some small issues