Skip to content

install.sh:fetch: don't use rm -rf with variable arguments#24

Open
SwuduSusuwu wants to merge 2 commits intonode-tensorflow:masterfrom
SwuduSusuwu:patch-1
Open

install.sh:fetch: don't use rm -rf with variable arguments#24
SwuduSusuwu wants to merge 2 commits intonode-tensorflow:masterfrom
SwuduSusuwu:patch-1

Conversation

@SwuduSusuwu
Copy link

@SwuduSusuwu SwuduSusuwu commented May 10, 2025

Purposes

  • Prevents massive filesystem destruction if root directory is passed.
  • The argument is the basename of the Uniform Resource Identifier passed to curl, which curl should not store as RO (thus no -f flag needed to remove).
  • The argument is a single file (thus no -r flag needed to remove).

@SwuduSusuwu
Copy link
Author

Can clone and make_install use just -r (can have the f flag removed?):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant