Conversation
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore and @dead-horse to be potential reviewers. |
fengmk2
commented
Jul 17, 2017
| return function(done) { | ||
| return function(callback) { | ||
| self.request(url, args) | ||
| .catch(done) |
4 tasks
popomore
approved these changes
Jul 17, 2017
Member
|
catch 放上面应该只处理当前 request 的错误，显示是会处理之前所有的 request 的异常。 不过 promise 的递归比较难维护。 |
Member
Author
|
callback twice 的历史问题终于找到根本原因 nodejs/node#14333 |
fengmk2
force-pushed
the
support-defaultArgs
branch
from
ecb7391 to
e9bd118
Compare
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 97.41% 97.83% +0.41%
==========================================
Files 4 4
Lines 542 553 +11
Branches 136 139 +3
==========================================
+ Hits 528 541 +13
+ Misses 14 12 -2
Continue to review full report at Codecov.
|
fengmk2
force-pushed
the
support-defaultArgs
branch
from
42ee7e8 to
aba453f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.