fix: prevent path traversal via directory prefix collision in _joinDirectoryName#1062
Open
vnykmshr wants to merge 1 commit intonode-formidable:masterfrom
Open
fix: prevent path traversal via directory prefix collision in _joinDirectoryName#1062vnykmshr wants to merge 1 commit intonode-formidable:masterfrom
vnykmshr wants to merge 1 commit intonode-formidable:masterfrom
Conversation
…rectoryName The startsWith check compared string prefixes, not filesystem paths. When uploadDir lacks a trailing separator (the default), sibling directories sharing the same prefix bypass the check. Use path.resolve + path.sep to ensure the resolved path is inside the upload directory, not just sharing a string prefix. Fixes node-formidable#1061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1061
The
startsWithcheck in_joinDirectoryName()compared string prefixes, not filesystem paths. WhenuploadDirlacks a trailing separator (the default —os.tmpdir()never includes one), sibling directories sharing the same prefix bypass the traversal check.Changes:
path.resolve()to normalize both paths before comparisonpath.septo the resolved directory, ensuring the path is inside the directoryTests added: