Folders and Files tinting & filtering customizations#65
Open
surinder-tsys wants to merge 1 commit intomasterfrom
Open
Folders and Files tinting & filtering customizations#65surinder-tsys wants to merge 1 commit intomasterfrom
surinder-tsys wants to merge 1 commit intomasterfrom
Conversation
|
Same here, can you outline purpose of it? :) |
Author
This PR contains the following:
|
Author
|
@tobiasKaminsky |
Author
|
@tobiasKaminsky I have extracted the fixes which can be up-streamed and here are the links:
Can you please go through them so that I can remove the up-streamed code from this PR. |
|
Remaining parts do not seem to be Magenta specific, so they can split up and also be upstreamed. |
surinder-tsys
commented
Apr 19, 2023
app/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt
Outdated
Show resolved
Hide resolved
surinder-tsys
commented
Apr 19, 2023
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java
Show resolved
Hide resolved
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
c4ac974 to
e588d0a
Compare
surinder-tsys
commented
May 25, 2023
| } | ||
|
|
||
| override fun onQueryTextSubmit(query: String): Boolean { | ||
| KeyboardUtils.hideKeyboardFrom(requireContext(), binding.root) |
Author
There was a problem hiding this comment.
@tobiasKaminsky This logic will hide the keyboard every time whenever user do search.
Let me know if this also has to be up-streamed.
surinder-tsys
force-pushed
the
nmc/1922-files
branch
2 times, most recently
from
7743c4e to
bbd2f50
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
3 times, most recently
from
1528d1f to
4f378ac
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
2 times, most recently
from
3c3ed5d to
4824021
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
4824021 to
99c2365
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
99c2365 to
4ec17af
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
4ec17af to
c183726
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
c183726 to
b0bb710
Compare
Closed
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
b0bb710 to
b145599
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
b145599 to
ba44c8b
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
02f8da1 to
e8f81ac
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
2 times, most recently
from
6392b4f to
98c5214
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
98c5214 to
43a5a12
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
43a5a12 to
956c93e
Compare
surinder-tsys
changed the title
1 task
surinder-tsys
changed the title
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
956c93e to
f419984
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
f419984 to
bb1d949
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
bb1d949 to
b28f11a
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
b28f11a to
2637d4d
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
2 times, most recently
from
8c90b4a to
95d92de
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
95d92de to
9d4c357
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
9d4c357 to
00d1d44
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
00d1d44 to
049af5f
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
049af5f to
0a466bc
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
0a466bc to
46561cc
Compare
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
46561cc to
1a13c81
Compare
Update UnifiedSearchFragment.kt. Commit id: 4fb3fb3 from branch bug/NMC-1652. NMC-2140: Tinting removed for folder and file icons and not overlaying icon for folders.
surinder-tsys
force-pushed
the
nmc/1922-files
branch
from
1a13c81 to
8cf3b0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NMC-1922: Filtering only folders and showing them as per NMC-2893 Task
Update UnifiedSearchFragment.kt.
Commit id: 4fb3fb3 from branch bug/NMC-1652.
NMC-3192: ExoPlayer seek forward and backward customization.
NMC-2140: Tinting removed for folder and file icons and not overlaying icon for folders.
Share icon changed.
NMC-4749: fix favourite files loading properly by moving ui operation to main thread