Only scroll images into view when they're added#3532
Merged
max-nextcloud merged 2 commits intomasterfrom Dec 7, 2022
Merged
Conversation
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
max-nextcloud
approved these changes
Dec 7, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
This makes a lot of sense. Thanks for looking into it.
Instead of scrolling each image into view after it's been loaded, only scroll images into view when they got added to the document. Fixes: #3531 Signed-off-by: Jonas <jonas@freesources.org>
max-nextcloud
force-pushed
the
fix/image_scrollintoview
branch
from
d8683b0 to
7f6f683
Compare
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to stable25 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
This was referenced Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of scrolling each image into view after it's been loaded, only scroll images into view when they got added to the document.
Fixes: #3531
Signed-off-by: Jonas jonas@freesources.org
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)