[Stable25] Backport of #3460 - Fix front matter rendering#3481
Merged
juliusknorr merged 3 commits intostable25from Nov 24, 2022
Merged
[Stable25] Backport of #3460 - Fix front matter rendering#3481juliusknorr merged 3 commits intostable25from
juliusknorr merged 3 commits intostable25from
Conversation
If the editor was loaded before the callback did not write the front matter content to the correct variable which resulted in dropping the front matter. This is fixed by not using the callback but a renderer function. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
1. Test if the correct front matter content is displayed 2. Test if the front matter survives closing and reopening the editor Skip common mark tests which we correctly interpret as front matter Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
requested review from
luka-nextcloud,
max-nextcloud,
mejo- and
vinicius73
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
juliusknorr
approved these changes
Nov 24, 2022
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Manual backport because command failed: #3460 (comment)
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)