Skip to content

Fix password displayed as username in Firefox password manager dialog#7709

Merged
MorrisJobke merged 3 commits intomasterfrom
fix-password-displayed-as-username-in-password-manager
Jan 11, 2018
Merged

Fix password displayed as username in Firefox password manager dialog#7709
MorrisJobke merged 3 commits intomasterfrom
fix-password-displayed-as-username-in-password-manager

Conversation

@danxuliu
Copy link
Member

@danxuliu danxuliu commented Jan 5, 2018

Fixes (in master) #7031

The problem was (besides the password manager ignoring autocomplete="off") that the password input element (in the HTML form) is cloned in a text input element, which is used to show the password in plain text when clicking on the Show password button. As it was a text input immediately followed by a password input Firefox seemed to assume that it had to be the username and ignored the real username field, no matter the value set for the autocomplete attribute (autocomplete="off" for the whole form, autocomplete="street-name" (because it is a supported autocomplete value that has nothing to do with login) or autocomplete="new-password" for the cloned text input, autocomplete="name/username/email" for the username text input, nor combinations of those).

Now the cloned text input is added after the password input, so Firefox no longer thinks that the cloned text input is the username field and the password manager dialog shows the proper username instead.

Chromium was not affected by the original issue (it also offers to save the credentials, but its password manager dialog showed the proper username), and it still works as before after the change.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants