[stable33] fix(files): Prevent file list from jumping when selecting visible files#58137
Merged
AndyScherzinger merged 3 commits intostable33from Feb 6, 2026
Merged
[stable33] fix(files): Prevent file list from jumping when selecting visible files#58137AndyScherzinger merged 3 commits intostable33from
AndyScherzinger merged 3 commits intostable33from
Conversation
nfebe
approved these changes
Feb 6, 2026
susnux
approved these changes
Feb 6, 2026
cristianscheid
approved these changes
Feb 6, 2026
Skip scrolling when a file is clicked if it's already within the visible viewport, avoiding the confusing list jump behavior. Fixes #54700 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Adjust test assertions to match the new behavior where scrolling is skipped for files already in the visible buffer. Tests now verify file existence rather than full visibility for files within the buffer. Signed-off-by: nfebe <fenn25.fn@gmail.com>
3b1ae5b to
67008ca
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58087
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.