Skip to content

[stable33] fix(files): Prevent file list from jumping when selecting visible files#58137

Merged
AndyScherzinger merged 3 commits intostable33from
backport/58087/stable33
Feb 6, 2026
Merged

[stable33] fix(files): Prevent file list from jumping when selecting visible files#58137
AndyScherzinger merged 3 commits intostable33from
backport/58087/stable33

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 6, 2026

Backport of #58087

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Feb 6, 2026
@backportbot backportbot bot added this to the Nextcloud 33 milestone Feb 6, 2026
@nfebe nfebe marked this pull request as ready for review February 6, 2026 15:19
@nfebe nfebe requested review from a team and skjnldsv as code owners February 6, 2026 15:19
@nfebe nfebe requested review from szaimen and removed request for a team February 6, 2026 15:19
@nfebe nfebe enabled auto-merge February 6, 2026 15:19
nfebe added 2 commits February 6, 2026 22:25
Skip scrolling when a file is clicked if it's already within the
visible viewport, avoiding the confusing list jump behavior.

Fixes #54700

Signed-off-by: nfebe <fenn25.fn@gmail.com>
Adjust test assertions to match the new behavior where scrolling is
skipped for files already in the visible buffer. Tests now verify file
existence rather than full visibility for files within the buffer.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@AndyScherzinger AndyScherzinger force-pushed the backport/58087/stable33 branch from 3b1ae5b to 67008ca Compare February 6, 2026 21:25
@AndyScherzinger
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit 70fa476 into stable33 Feb 6, 2026
123 of 124 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/58087/stable33 branch February 6, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants