Skip to content

Comments

fix(settings): Also verify that trusted_proxies only contains IP addresses (with range)#44483

Merged
susnux merged 1 commit intomasterfrom
fix/setup-check-validate-trusted-proxies
Mar 26, 2024
Merged

fix(settings): Also verify that trusted_proxies only contains IP addresses (with range)#44483
susnux merged 1 commit intomasterfrom
fix/setup-check-validate-trusted-proxies

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 26, 2024 •
edited
Loading

Summary

trusted_proxies only handles IPv4 and IPv6 addresses, optionally with CIDR range notation, so we should validate this too. As it is a common mistake to put host names into this.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Mar 26, 2024
@susnux susnux added this to the Nextcloud 29 milestone Mar 26, 2024
@susnux susnux requested review from a team, Altahrim, ArtificialOwl, come-nc and sorbaugh and removed request for a team March 26, 2024 11:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 26, 2024
View reviewed changes
@susnux susnux force-pushed the fix/setup-check-validate-trusted-proxies branch from 8547a5d to a4274c1 Compare March 26, 2024 13:27
come-nc
come-nc reviewed Mar 26, 2024
View reviewed changes
@susnux @come-nc
fix(settings): Also verify that trusted_proxies only contains IP ad…
14addf3 
…dresses (with range)

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/setup-check-validate-trusted-proxies branch from d6b536f to 14addf3 Compare March 26, 2024 13:51
@susnux susnux requested a review from come-nc March 26, 2024 13:51
@Altahrim Altahrim mentioned this pull request Mar 26, 2024
Merged
@susnux
Copy link
Contributor Author

susnux commented Mar 26, 2024

/backport to stable28

come-nc
come-nc approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra points if you add a unit test.

@susnux susnux merged commit 5100c7e into master Mar 26, 2024
@susnux susnux deleted the fix/setup-check-validate-trusted-proxies branch March 26, 2024 17:38
@backportbot backportbot bot mentioned this pull request Mar 26, 2024
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feedback-requested

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux @Altahrim @come-nc