Add fallback when a there is no preview for a version#38467
Conversation
f3981d8 to
48bf654
Compare
szaimen
left a comment
There was a problem hiding this comment.
One small suggestion, apart from that tested and works and LGTM!
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
nimishavijay
left a comment
There was a problem hiding this comment.
Good call! The "After" version definitely looks better as you said, and agreed with @szaimen that it can be a lighter color :)
|
/compile amend / |
ec5c8f9 to
1b3fbb1
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
1b3fbb1 to
e8eb8a9
Compare
|
The backport to stable27 failed. Please do this backport manually. More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable26 failed. Please do this backport manually. More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable25 failed. Please do this backport manually. More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport to stable25 |
|
The backport to stable25 failed. Please do this backport manually. More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
|
The backport to stable26 failed. Please do this backport manually. More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable25 failed. Please do this backport manually. More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable27 failed. Please do this backport manually. More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
Must be backported manually if needed, it seems 😞 |
Fix #37067
@nextcloud/designers Unsure about the new icon. Do you prefer to go with the "After" version, or the "Firefox" one?
No icon could be confusing because the user might think that the file is empty, even though it might not.