Conversation
…/vue lib update Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
Pytal,
skjnldsv and
szaimen
and removed request for
a team
Member
Author
|
The old selector is also used here, not sure it needs adjusting? Line 223 in 9012e89 |
Member
Author
|
/backport to stable26 |
Member
Author
|
/backport to stable25 |
skjnldsv
approved these changes
Mar 7, 2023
szaimen
approved these changes
Mar 7, 2023
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing this Joas! :)
szaimen
deleted the
bugfix/noid/fix-acceptance-test-selector-after-vue-lib-update
branch
This was referenced Mar 7, 2023
This was referenced Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…/vue lib update
Regression from #37005
Checklist