fix: Make sure to reopen session before cleaning#35723
Merged
Conversation
Otherwise restoring the requesttoken would reopen and read the existing session data and restore it instead of clearing Signed-off-by: Julius Härtl <jus@bitgrid.net>
This was referenced Dec 10, 2022
juliusknorr
requested review from
ChristophWurst,
PVince81,
blizzz and
nickvergessen
Member
Author
|
/backport to stable25 |
ChristophWurst
approved these changes
Dec 14, 2022
PVince81
approved these changes
Dec 20, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 assuming this is still useful, probably for other use cases
|
The backport to stable25 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise restoring the requesttoken would reopen and read the existing
session data and restore it instead of clearing.
This is only an issue if the session clean method is called without having a
session already open (e.g. with the
@UseSessioncontroller annotation. Thisis the reason why the regular logout works but user_saml not.
There is a hot fix available for user_saml in nextcloud/user_saml#677 so this could be addressed without another server release.
Signed-off-by: Julius Härtl jus@bitgrid.net
Checklist