Merged
Conversation
Pytal
requested review from
CarlSchwan,
JuliaKirschenheuter,
PVince81 and
artonge
Member
Author
|
/backport to stable25 |
artonge
approved these changes
Nov 21, 2022
artonge
reviewed
Nov 21, 2022
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Alignment is a bit weird, no ?
I would remove the left margin
Member
Author
Was done similarly to the global search menu Can change it though @nimishavijay @jancborchardt? |
Member
|
Nice! I think we could remove the left margin as well as the bolding to make it similar to the vue component :)
|
Pytal
force-pushed
the
enh/a11y-share-search-label
branch
from
b08697c to
72425cc
Compare
Pytal
added
4. to release
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-share-search-label
branch
from
72425cc to
20da3d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot