Disable style override on vue-select elements#35165
Conversation
|
/backport to stable25 |
artonge
left a comment
There was a problem hiding this comment.
This is only adding :not([class^=vs__]) filter, right ?
For context, vue-select uses vs_ prefix for its classes.
Looks good :)
Yes :) added a comment https://github.com/nextcloud/server/blob/fix/vue-select-styles/core/css/inputs.scss#L32 |
- PENDING nextcloud/server#35165 Signed-off-by: Christopher Ng <chrng8@gmail.com>
- PENDING nextcloud/server#35165 Signed-off-by: Christopher Ng <chrng8@gmail.com>
- PENDING nextcloud/server#35165 Signed-off-by: Christopher Ng <chrng8@gmail.com>
4d7da2f to
8784aa2
Compare
|
Rebased |
PVince81
left a comment
There was a problem hiding this comment.
👍 assuming there is no better way
- Disable style override on NcActionButton with `:not(.action-button)` due to increased specificity over scoped Vue styles when only `:not([class^="vs__"])` is added Signed-off-by: Christopher Ng <chrng8@gmail.com>
8784aa2 to
d3d5034
Compare
|
Also disable style override on NcActionButton with |



This fixes the styling of vue-select elements as we will soon use the https://github.com/sagalbot/vue-select library in place of the https://github.com/shentao/vue-multiselect library