#34969 Fix AppMenu icons for firefox

[cupcakearmy]

• fixes [Bug]: Icons in the AppMenu not showing properly in Firefox #34969

[cupcakearmy]

@szaimen thanks for looking at this :) Is there any way this could land in 25 and not 26? it's quite a critical visual bug for anyone using firefox, as the icons on the homescreen simply stop showing up :)

[skjnldsv]

@cupcakearmy it will make it for 26 first, then backported to 25

[skjnldsv]

/backport to stable25

[skjnldsv]

Can you rebase, compile and ship the compiled dist files too @cupcakearmy please? :)

[cupcakearmy]

@skjnldsv I see :) perfect!

Rebase on what? I'm not a huge rebase expert xD

[cupcakearmy]

I tried installing the deps in the github codespaces (don't want to install it locally) but for some reason I get errors when running make dev-setup (to rebuild the dist file)

Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/nextcloud/strengthify.git

Otherwise running npm i leaves ~25 peer deps uninstalled and the build fails.

I don't have time to go down this rabbit hole unfortunately. Feel free to use the code at free will.

[szaimen]

Thanks for the PR! I've taken over and pushed the fix to #35029

[cupcakearmy]

Awesome, thanks!