File reference: fallback icon to file type if no preview#34401
Merged
nickvergessen merged 1 commit intomasterfrom Oct 6, 2022
Merged
File reference: fallback icon to file type if no preview#34401nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
Member
Author
|
/backport to stable25 |
juliusknorr
approved these changes
Oct 4, 2022
juliusknorr
reviewed
Oct 4, 2022
…ovider for this type Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
fix/file-reference-no-preview-fallback-image
branch
from
396bdd7 to
3c86afc
Compare
nickvergessen
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the preview manager does not support the file, fallback to the file type icon.
We still have to improve the image size. Worst case scenario, the icon is way more high than large.