Use the unjailed-path in OC_Helper::getStorageInfo() for files located in SharedStorage.

[rotdrop]

The current implementation already switches the storage-backend to $storage->getSourceStorage(). However, it then calls
$rootInfo->getInternalPath() which returns the internal path relative to the storage where the share is mounted. This is wrong, we need also to unjail the path. Compare, e.g., with OCA\Files_Sharing\SharedStorage::file_get/put_contents() for the
"logic".

Fix #30992

Signed-off-by: Claus-Justus Heine himself@claus-justus-heine.de

[CarlSchwan]

Do you know a test case there this previously broke and now is fixed?

[rotdrop]

Do you know a test case there this previously broke and now is fixed?

When listing any shared folder deeper than 1 level I have error messages in my logs like

Error: disk_free_space(): No such file or directory at /var/www/orgacloud/nextcloud/lib/private/Files/Storage/Local.php#381 /var/www/orgacloud/nextcloud/lib/private/Log/ErrorHandler.php:95

That they do not show up more often is probably caused by the following fall-back to the dirname:

server/lib/private/Files/Storage/Local.php

Lines 377 to 380 in eb19270

	if (!is_dir($sourcePath)) {
	// disk_free_space doesn't work on files
	$sourcePath = dirname($sourcePath);
	}

which means that just listing a shared folder will not trigger the error messages, but give wrong results.

[icewind1991]

Looks good

[CarlSchwan]

Thanks!

[szaimen]

samba failure unrelated

[szaimen]

/backport to stable23

[CarlSchwan]

/backport to stable22

[nils-schween]

Me too, I also experience the same issue with nextcloud 23.0.2. I added the patch manually. I will report if it worked.

@update: It worked. The errors disappeared.
Thanks for fixing it.

[syuo7]

Me too, I also experience the same issue with nextcloud 23.0.2. I added the patch manually. I will report if it worked.

How to apply this hot fix?
Thank you.

[nils-schween]

@syuo7 At the top of this page, there is tab "Commits". If you click it, you will see which file is changed and how it is changed.
In this case it is the file 'lib/private/legacy/OC_Helper.php'. I manually edited this file of my Nextcloud installation on my server, i.e. I added the green parts and removed the red parts. If you do so, make a copy of 'OC_Helper.php', in case it does not work you can restore the file.

[szaimen]

Yes, the issue will be fixed with 23.0.3 and 22.2.6