NMC-552 Move filename/size out of the download button#28643
Merged
skjnldsv merged 6 commits intonextcloud:masterfrom Sep 2, 2021
Merged
NMC-552 Move filename/size out of the download button#28643skjnldsv merged 6 commits intonextcloud:masterfrom
skjnldsv merged 6 commits intonextcloud:masterfrom
Conversation
Salvador1313
approved these changes
Aug 30, 2021
Member
|
Please do not include the change in the 3rdparty submodule in here. In addition the commit is missing a Signed-of-by message as described in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work |
artonge
requested changes
Aug 31, 2021
Contributor
|
I would also add some space above the .directDownload #downloadFile {
...
margin-top: 16px;
} |
085235c to
773898d
Compare
artonge
approved these changes
Sep 1, 2021
Contributor
artonge
left a comment
There was a problem hiding this comment.
Need DCO, else looks good :)
git rebase HEAD~6 --signoff
git push --force-with-lease origin NMC-552
skjnldsv
approved these changes
Sep 1, 2021
Pytal
reviewed
Sep 1, 2021
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
Signed-off-by: Sangramsinh Desai <sangramsinh.desai@t-systems.com> Signed-off-by: sangramsinh.desai@t-systems.com <sangramsinh.desai@t-systems.com>
943ca47 to
bc6b496
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Member
|
/backport to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guest view below changes done