Conversation
|
Well this is "public api", it mostly means 22, we so far never backported stuff on it. But then again new things don't break old consumers of the API so should be okay to backport. |
nickvergessen
left a comment
There was a problem hiding this comment.
Approving apart of the since version which we have to clarify
|
So we also have |
|
So i set this to |
c9021b0 to
c69f712
Compare
|
@nickvergessen Is 19 ok? Or better 20? Unfortunately it depends a bit on this question, when we can start using it. 🙈 |
|
If it's up to me I would only put it in 21 |
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
c69f712 to
f02362e
Compare
|
Ah, that's sad. But ok. 🤷♂️ It's 21 again and i'll have a look onto this validation. 😉 |
|
/backport to stable21 |
|
Probably wildly off-topic. But is there a reason we need all this in core... wouldn't it be enough if apps can provide such things themselves? |
|
The idea was to have "stable api versioning" with the nextcloud version so if a moible client supports a given version it also doesn't break with any of those parameters but handles them gracefully. |
|
@nickvergessen you ok now to merge this? |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Includes the form-richObject for Events/Activities. Ref. nextcloud/forms#789
@nickvergessen I'm not completely sure, what to set as
since. I now set21.0.1as this seems to me like the 'next' release. However, this PR is now on master (so22.0.0?), Forms still supports 19, so19.0.10with a backport? 🙈