Show group backends in occ group:list --info and group:info#25660
Merged
rullzer merged 1 commit intonextcloud:masterfrom Mar 5, 2021
Merged
Show group backends in occ group:list --info and group:info#25660rullzer merged 1 commit intonextcloud:masterfrom
rullzer merged 1 commit intonextcloud:masterfrom
Conversation
noiob
force-pushed
the
feature/add-backend-list-groups
branch
3 times, most recently
from
f8e8ac6 to
c5b9ee4
Compare
noiob
force-pushed
the
feature/add-backend-list-groups
branch
from
c5b9ee4 to
45c2dbc
Compare
noiob
force-pushed
the
feature/add-backend-list-groups
branch
2 times, most recently
from
d9aa41f to
0c8b322
Compare
Contributor
|
Thanks a lot 👍 Please migrate to CamelCase for variable names. |
noiob
force-pushed
the
feature/add-backend-list-groups
branch
from
0c8b322 to
5e8a029
Compare
Contributor
Author
done, hope I didn't miss any! |
noiob
force-pushed
the
feature/add-backend-list-groups
branch
from
5e8a029 to
a3542de
Compare
blizzz
reviewed
Feb 17, 2021
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
That's great, thank you for the contribution!
noiob
force-pushed
the
feature/add-backend-list-groups
branch
6 times, most recently
from
0e1f3da to
9b556e5
Compare
Contributor
Author
|
@blizzz Thanks for the comprehensive review, I tried to implement all the changes you requested, it feels a good bit more elegant now 😄 Edit: I have opened a PR for the issue in sharebymail SettingsManager at #25778 |
noiob
force-pushed
the
feature/add-backend-list-groups
branch
2 times, most recently
from
0a6c0b8 to
dce3097
Compare
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
noiob
force-pushed
the
feature/add-backend-list-groups
branch
from
dce3097 to
2796ef8
Compare
blizzz
approved these changes
Mar 2, 2021
blizzz
approved these changes
Mar 2, 2021
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
looks good, tested + works, has tests, 👍
rullzer
approved these changes
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using LDAP, it may be necessary to check whether a group is managed by LDAP or the Database backend. I've added that info both to the
group:listcommand when run with--info(as to not introduce breaking changes) and to the newgroup:infocommand. I've tried to keep them similar touser:list --infoanduser:info.