Phone number validation and search

[nickvergessen]

• Requires 3rdparty giggsey/libphonenumber-for-php Add giggsey/libphonenumber-for-php 3rdparty#539
• Validate that the phone number is actually a phone number
• Find a decent default region code we can use (admin setting? reverse try language selection?)
• Store phone numbers in a defined format (Recommended https://en.wikipedia.org/wiki/E.164 supported by the library)
• Store phone numbers (and other entries?) individually so we can search by them in a meaning full way instead of wildcard searching the json blob in oc_accounts.
• Add an OCS Api to search again account data and return federation ids
• Add a unit test for the cleaning of the phone number
• Add a unit test for the search endpoint
• Add integration tests for the search endpoint
• Need a way to retrigger a full sync of the accounts table

Use https://giggsey.com/libphonenumber/ to find valid testing numbers

Search API

• Endpoint: POST ocs/v2.php/cloud/users/search/by-phone
• Data (all 3 number formats are valid):

{
	"location": "DE",
	"search": {
		"Unique-Idenifier-For-Contact-1": [
			"0711/25 24 28-90"
		],
		"Unique-Idenifier-For-Contact-2": [
			"+49 711/25 24 28-91",
			"0049 711/25 24 28-92"
		]
	}
}

• Response (map of provided identifier and cloudId):

{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 200,
      "message": "OK"
    },
    "data": {
      "Unique-Idenifier-For-Contact-1": "admin@localhost/"
    }
  }
}

[nickvergessen]

As per opening post, the lib to validate/unify phone numbers needs a default region.

Best I have in mind is an admin setup warning about the missing region and until that is set only allow +49 phone numbers and lie to the lib that the default region is EN. Falling back to default language "would also work", but e.g. Austrian numbers would be German as they use the same language, so it's not very sensitive/accurate.

Opinions on this? @MorrisJobke @rullzer @ChristophWurst

[ChristophWurst]

As per opening post, the lib to validate/unify phone numbers needs a default region.

Would the locale be more accurate than the language? Like if one sets de_AT then you can guess the country. Possible not 100% accurate either but it seems like there is a locale for many countries.

[MorrisJobke]

Best I have in mind is an admin setup warning about the missing region and until that is set only allow +49 phone numbers and lie to the lib that the default region is EN.

Doesn't sound too bad IMO.

[nickvergessen]

Anyone an idea about:

• Need a way to retrigger a full sync of the accounts table

[nickvergessen]

Added a repairstep to validate the existing entries. This is now ready to review.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 299: failure

sqlite

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 4 failures:

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-30, -74)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

2) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (48, 95)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

3) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-64, 13)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

4) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (57, -93)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

mariadb10.4-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 4 failures:

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-63, -90)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

2) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (30, 20)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

3) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-27, 81)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

4) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (73, -37)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

mysql8.0-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 4 failures:

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-63, -99)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

2) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (17, 54)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

3) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-98, 25)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

4) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (92, -10)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

postgres11-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 4 failures:

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-26, -83)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

2) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (44, 10)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

3) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-92, 80)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

4) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (52, -72)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105