Set the moment locale even earlier#21778
Merged
MorrisJobke merged 1 commit intomasterfrom Jul 9, 2020
Merged
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
GretaD,
ahstro,
danxuliu,
marcoambrosini and
nickvergessen
Member
Author
|
/backport to stable19 |
nickvergessen
approved these changes
Jul 9, 2020
Member
Author
|
/backport to stable18 |
Member
Author
|
jsunit passes. I'm so relieved. |
This was referenced Jul 9, 2020
Contributor
|
Very nice. I think there are some reports around for that problem. |
Member
|
No, it's not about the issue you have in mind |
Contributor
I know which issue you are talking about ;) For the sake of completeness: #14907 (that seems pretty much what is fixed with this pr) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did this early, but not early enough.
Steps to reproduce
Master: (Relative) time shown in English
Here: (Relative) time shown in your set language/locale