Upload part size as S3 parameter instead of constant value#21317
Upload part size as S3 parameter instead of constant value#21317rullzer merged 1 commit intonextcloud:masterfrom FlorentCoppint:s3_upload_part_size
Conversation
| protected $timeout; | ||
|
|
||
| /** @var int */ | ||
| protected $upload_part_size; |
There was a problem hiding this comment.
| protected $upload_part_size; | |
| protected $uploadPartSize; |
There was a problem hiding this comment.
Please use camelCase for variables here.
| $this->test = isset($params['test']); | ||
| $this->bucket = $params['bucket']; | ||
| $this->timeout = !isset($params['timeout']) ? 15 : $params['timeout']; | ||
| $this->upload_part_size = !isset($params['upload_part_size']) ? 524288000 : $params['upload_part_size']; |
There was a problem hiding this comment.
Also here for variable and param.
There was a problem hiding this comment.
Also here for variable and param.
Hi, are you sure for parameter name ? A lot of parameters are using "underscore style" in Nextcloud
There was a problem hiding this comment.
|
If possible please squash the commits and add the signoff. As per https://github.com/nextcloud/server/pull/21317/checks?check_run_id=750683865
should be enough but that might change with additional commits. |
Some S3 providers need a custom upload part size (500 MB static value in Nextcloud). Here is a commit to change this value via S3 configuration, instead of using S3_UPLOAD_PART_SIZE constant. A new parameter is added for an S3 connection : uploadPartSize Signed-off-by: Florent <florent@coppint.com>
|
Do I have something to do about failed Continuous Integration test ? |
I don't think so. |
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Can you also update the config.sample.php?
I can, but there is no S3 example configuration in config.sample.php :( |
ah mm goodpoint |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable19 |
4 participants
Some S3 providers need a custom upload part size (500 MB static value in Nextcloud).
Here is a commit to change this value via S3 configuration, instead of using S3_UPLOAD_PART_SIZE constant.
A new parameter is added for an S3 connection : uploadPartSize
Signed-off-by: Florent florent@coppint.com