Make the translation sanitization optional#20976
Conversation
942aa1f to
73aa1f2
Compare
georgehrke
left a comment
There was a problem hiding this comment.
I'm not entirely sure about this approach, because it requires you to add {}, undefined, {sanitize: false} to all translations.
Devices & Sessions is a case where we know it will break, but there are many other cases where the english source version will work fine, but issues will only occur in specific languages for certain strings.
I think that we should keep the current t for legacy reasons and introduce a new translateUnescaped, which we can use whenever we are inside a templating system like handlebars or vue that takes care of escaping for us.
Shoot a PR that fixes is and is backportable and I'll close mine. This solution is what @nickvergessen, @rullzer and I discussed and settled on. |
Withdrawing my review in that case. Fine by me. |
|
I just made dirty workaround until this isn`t merged. |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
73aa1f2 to
069d02a
Compare
|
/backport to stable19 |
|
/backport to stable18 |
rullzer
left a comment
There was a problem hiding this comment.
I'm still a fan. But yeah I guess so :S
We can fix it properly once we have a consensus on what a proper solution is. |
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
Fixes #18662
Ref #18741