Pass old value to user triggerChange hook & do not update unchanged attributes#15052
Merged
MorrisJobke merged 2 commits intomasterfrom Apr 11, 2019
Merged
Pass old value to user triggerChange hook & do not update unchanged attributes#15052MorrisJobke merged 2 commits intomasterfrom
MorrisJobke merged 2 commits intomasterfrom
Conversation
MorrisJobke
requested review from
ChristophWurst,
blizzz,
nickvergessen and
rullzer
Member
Author
|
Okay - this is already causing the issue. Let's shrink it down furthermore. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
fix/noid/pass-oldvalue
branch
from
878aea2 to
36618b1
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
changed the title
Member
Author
|
This is ready to be reviewed. It contains two commits:
|
ChristophWurst
approved these changes
Apr 11, 2019
rullzer
approved these changes
Apr 11, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
If CI is happy I'm fine with this
MorrisJobke
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14967 and #14566 that only passes the additional value for the old value of the attribute.
Also includes that some attributes should not be updated if their value hasn't changed.