Implement quickaccess removal for delete-action#14723
Closed
Implement quickaccess removal for delete-action#14723
Conversation
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 17094: failureTESTS=ui-regression
|
Contributor
Contributor
Author
|
@tacruc That's a good hint for an edgecase! I have not considered that, i will look into it, thanks! :) |
Member
|
Bump? :) |
Member
|
This also happens for adding favorites, the quick access doesn’t update. Is this maybe related @newhinton? :) |
Contributor
Author
|
i'll take a look at it when i give a try at #18607 |
Member
|
@newhinton Any update on this one? |
Contributor
Author
|
ahh sorry, i completely forgot since i need to fix my app for nc20 anyway, i'll take a look at this simultaneously |
Member
|
Closing as there has been no traction on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #13963
This removes a folder from the quickaccess navigationbar before it is deleted.
It also removes every favorited subfolder of that given folder, so that no dead links are left in the sidebar.