Restoring file version gives incorrect filename and no extension

[tflidd]

Steps to reproduce

1. Create file, make changes to create different versions
2. Go on file and show details, go to the versions tab
3. Download last version (click on the area marked in this screenshot):
   

This issues was reported by one of our users on the forum: https://help.nextcloud.com/t/nc15-restoring-file-version-gives-incorrect-filename-and-no-extension/43746

Expected behaviour

Download file with correct extension and a file name which relates to the actual filename (either the real filename, or filename_timestamp.extension).

Actual behaviour

You get a file without extension, and the filename is just a time stamp.

Server configuration

see forum post. I reproduced it on a Debian/Apache/mod_php system.

[violoncelloCH]

I can reproduce this with 15.0.0 however not with the current master.

[Beeez]

Has there been much progress on this at all? I am seeing the same for my file downloads in versioning.

Edit: I am on 15.0.2

[violoncelloCH]

I can't reproduce it with 15.0.3RC1
can you test it, if it works for you with 15.0.3(RC1)?

[Beeez]

Is this not available yet in stable branch?

[violoncelloCH]

@Beeez It's the first release candidate (RC1) so it's only available in the beta branch yet... there will be RC2 and RC3 and on 02-21-2019 NC 15.0.3 will be released to the stable branch :)

[Beeez]

Is there anywhere I can see changes made in RC1 and can potentially apply them to my own instance?

I had noticed this line and made changes however it did not affect the downloadUrl

server/apps/files_versions/js/versionmodel.js

Line 64 in 530e39b

return OC.linkToRemoteBase('dav') + '/versions/' + this.get('user') + '/versions/' + this.get('fileId') + '/' + this.get('id');

[violoncelloCH]

#13912 this PR mentions all merged PRs for 15.0.3RC1

[Beeez]

Not seeing 13239 as part of those fixes?

[violoncelloCH]

as I said, there are the merged PRs listed not the issues...

[Beeez]

One last thing which i cant tell is part of 15.03RC1. When I am inside of a shared folder and check file versions, the download URL is using my own user folder for grabbing the versioned file (which does not exist) rather than pointing to the source of the actual file stored in _groupfolders/versions/<folder Number>/<fileid>

[Beeez]

I have updated to 15.0.4 but file versioning still downloads without extensions.