Skip to content

perf: Lazy load dashboard components#964

Merged
juliusknorr merged 1 commit intomasterfrom
perf/lazy-dashboard
Feb 9, 2023
Merged

perf: Lazy load dashboard components#964
juliusknorr merged 1 commit intomasterfrom
perf/lazy-dashboard

Conversation

@juliusknorr
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr commented Feb 8, 2023

Save loading and evaluating larger amounts of javascript on the early page load.

@juliusknorr juliusknorr added the enhancement New feature or request label Feb 8, 2023
@juliusknorr juliusknorr requested a review from julien-nc February 8, 2023 16:34
@juliusknorr
Copy link
Copy Markdown
Member Author

@julien-nc Might be something nice for all the integration widgets at some point :)

@julien-nc
Copy link
Copy Markdown
Member

julien-nc commented Feb 8, 2023

👍
It does not work with a subpath on my local setup. I see a request to
https://nextcloud.local/apps/notes/js/notes-commons.js?v=1fe6d2ef17a17417d45d
while it should be
https://nextcloud.local/dev/server26/apps/notes/js/notes-commons.js?v=1fe6d2ef17a17417d45d

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Copy Markdown
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juliusknorr juliusknorr merged commit 06bf0e1 into master Feb 9, 2023
@juliusknorr juliusknorr deleted the perf/lazy-dashboard branch February 9, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants