Add integration test by julien-nc · Pull Request #178 · nextcloud/integration_github

julien-nc · 2026-03-14T00:42:26Z

Use phpunit 11 to get the external dependency feature (used in integration tests)
Bump min NC version to 33 and max to 34 because phpunit 11 only supports php >= 8.2 and NC 33 is the first to drop support for php 8.1.
Update composer dependencies
Add oauth integration test that performs a full oauth flow with credentials stored as repo secrets (with totp support because we can't perform device validation per email 😁)
Add other integration tests that depend on the oauth test so we know we have a token stored in the DB
- Get notifications for the dashboard widget
- Search for the search providers
- Issue/pr reference provider
- Code reference provider
Fix issue in the issue/pr reference provider: When resolving links to a comment that does not exist (like https://github.com/nextcloud/server/issues/1#issuecomment-1), the reference object contained an invalid value for the comment which resulted in a crash of the widget. That's solved by acting like it's just an issue/pr link when the comment was not found.

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

…he oauth one Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

…rom nextcloud/.github Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

oleksandr-nc · 2026-03-15T06:11:37Z

.github/workflows/phpunit-mysql.yml

-        if: steps.check_integration.outcome == 'success'
-        working-directory: apps/${{ env.APP_NAME }}
-        run: composer run test:integration
+      #- name: Check PHPUnit integration script is defined


why we are commenting duplicated tests instead of removing?

oleksandr-nc · 2026-03-15T06:13:43Z

tests/integration/GitHubCodeReferenceIntegrationTest.php

+class GitHubCodeReferenceIntegrationTest extends TestCase {
+	private GithubCodeReferenceProvider $referenceProvider;
+	private SecretService $secretService;
+	private IConfig $config;


Is it used somewhere?

oleksandr-nc · 2026-03-15T06:15:51Z

tests/integration/GithubOauthIntegrationTest.php

+
+namespace OCA\Github\Tests\Integration;
+
+require_once __DIR__ . '/GitHubHtml.php';


Maybe the other test files should have this or as alternative could we add these classes to the autoload-dev section in composer.json?

oleksandr-nc · 2026-03-15T06:19:13Z

tests/phpunit.xml

-  </coverage>
+  </source>
  <testsuite name="GitHub integration App Tests">
    <directory suffix="Test.php">.</directory>


The unit test config scans . recursively, picking up integration tests too.
Maybe we should consider excluding the integration/ directory with something like <exclude>./integration</exclude>

This way test:unit only runs unit tests and test:integration only runs integration tests.

oleksandr-nc · 2026-03-15T06:26:12Z

.github/workflows/phpunit-mysql.yml


      - name: Skipped
        # Fail the action when neither unit nor integration tests ran
        if: steps.check_phpunit.outcome == 'failure' && steps.check_integration.outcome == 'failure'


steps.check_integration.outcome - was commented out

oleksandr-nc · 2026-03-15T06:28:22Z

tests/integration/GitHubSearchIntegrationTest.php

+			$this->assertMatchesRegularExpression('/^[⑁⦿] .+#\d+$/u', $expectedSubline, 'Subline should match expected format');
+		}
+	}
+}


nit: maybe adding tearDown() somewhere in this file will be a good idea to clean OAuth flow data to not affect any other tests that can be executed later and to revoke token from GitHub

oleksandr-nc · 2026-03-15T06:32:32Z

tests/integration/GitHubHtml.php

+	public static function findAuthorizeForm(DOMXPath $selector): ?DOMElement {
+		return self::findForm($selector, [
+			'//form[contains(@class, "js-oauth-authorize-form")]',
+			'//form[contains(@class, "js-oath-authorize-form")]',


can we add a comment here what is "js-oath" ? from quick search in the internet, I was not able to find such form.

julien-nc force-pushed the enh/noid/oauth-integration-test branch 12 times, most recently from b63d540 to a9c420a Compare March 14, 2026 16:19

julien-nc changed the title ~~Add oauth integration test~~ Add integration test Mar 14, 2026

julien-nc force-pushed the enh/noid/oauth-integration-test branch 5 times, most recently from ca3b0ce to 886e029 Compare March 15, 2026 00:25

julien-nc added 5 commits March 15, 2026 01:28

test: add oauth integration test

329a8c1

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

add integration test file focusing on notification and depending on t…

6327861

…he oauth one Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

update composer dependencies

25e5873

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

bump min/max supported nc version to 33/34. use psalm-matrix action f…

eb2f2e2

…rom nextcloud/.github Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

add search integration tests

0e7cef3

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

julien-nc force-pushed the enh/noid/oauth-integration-test branch from 886e029 to 9f9b46e Compare March 15, 2026 00:28

julien-nc added 4 commits March 15, 2026 01:36

fix deprecated phpunit stuff

47ebde6

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

add issue/pr reference integration tests

4ff89a5

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

fix(issue-pr-ref): handle unexisting comment number in issue/pr URL

a98da43

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

add code reference integration tests

5631c35

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

julien-nc force-pushed the enh/noid/oauth-integration-test branch from 9f9b46e to 5631c35 Compare March 15, 2026 00:36

julien-nc marked this pull request as ready for review March 15, 2026 00:40

julien-nc requested review from kyteinsky and oleksandr-nc as code owners March 15, 2026 00:40

oleksandr-nc approved these changes Mar 15, 2026

View reviewed changes

oleksandr-nc reviewed Mar 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration test#178

Add integration test#178
julien-nc wants to merge 9 commits intomainfrom
enh/noid/oauth-integration-test

julien-nc commented Mar 14, 2026 •

edited

Loading

Uh oh!

oleksandr-nc Mar 15, 2026

Uh oh!

oleksandr-nc Mar 15, 2026

Uh oh!

oleksandr-nc Mar 15, 2026

Uh oh!

oleksandr-nc Mar 15, 2026

Uh oh!

oleksandr-nc Mar 15, 2026

Uh oh!

oleksandr-nc Mar 15, 2026 •

edited

Loading

Uh oh!

oleksandr-nc Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		namespace OCA\Github\Tests\Integration;

		require_once __DIR__ . '/GitHubHtml.php';

Conversation

julien-nc commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleksandr-nc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

oleksandr-nc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

oleksandr-nc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

oleksandr-nc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

oleksandr-nc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

oleksandr-nc Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oleksandr-nc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

julien-nc commented Mar 14, 2026 •

edited

Loading

oleksandr-nc Mar 15, 2026 •

edited

Loading